ocp_resources/resource.py (1)

504-505: Add explicit type annotation for consistency

Most ApiGroup constants declare : str. Consider aligning JAEGERTRACING_IO for consistency and static typing.

-        JAEGERTRACING_IO = "jaegertracing.io"
+        JAEGERTRACING_IO: str = "jaegertracing.io"

ocp_resources/jaeger.py (2)

15-33: Validate strategy input (early fail on invalid values)

Constrain strategy to accepted values to catch typos at construction time.

-from typing import Any
+from typing import Any
@@
     def __init__(
@@
-        super().__init__(**kwargs)
+        super().__init__(**kwargs)
+
+        allowed_strategies = {"allInOne", "production"}
+        if strategy is not None and strategy not in allowed_strategies:
+            raise ValueError(f"Invalid strategy '{strategy}'. Allowed: {sorted(allowed_strategies)}")

Optionally, tighten the type hint:

-from typing import Any
+from typing import Any, Literal
@@
-        strategy: str | None = None,
+        strategy: Literal["allInOne", "production"] | None = None,

---

34-50: Don’t wipe existing spec on repeated to_dict() calls

Resetting self.res["spec"] = {} can drop prior fields if to_dict() is called more than once. Prefer merging and only overriding when arguments are provided.

-        if not self.kind_dict and not self.yaml_file:
-            self.res["spec"] = {}
-            _spec = self.res["spec"]
-
-            # If no strategy is set, default to "allInOne"
-            _spec["strategy"] = self.strategy or "allInOne"
-
-            if self.ingress is not None:
-                _spec["ingress"] = self.ingress
-
-            if self.collector is not None:
-                _spec["collector"] = self.collector
+        if not self.kind_dict and not self.yaml_file:
+            _spec = self.res.setdefault("spec", {})
+
+            if self.strategy is not None:
+                _spec["strategy"] = self.strategy
+            else:
+                _spec.setdefault("strategy", "allInOne")
+
+            if self.ingress is not None:
+                _spec["ingress"] = self.ingress
+
+            if self.collector is not None:
+                _spec["collector"] = self.collector

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.